Sorry for any debugging that you might have to do in that code. I'll leave it up to you to deallocate them in the event of a match.Īgain, it's been a long time since I've done C++, but that's my take. The old "deleted" nodes are not actually deleted, they are simply removed from the chain of pointers. Your program has what is known as a memory leak. if (iter = NULL) Īs others have stated, you need to be deallocating the memory. delete_item(node* head, int x) and so on. I'm not sure if C supports member functions, but if not, you should be using parameter passing, e.g. It's been ages since I've done C++, but here are my observations:įirst off, you're using global variables, which is ill-advised. Struct node* delete_item_from_list(struct node* head) void delete_item(struct node** list, int x) The first part that deals with the head as a special case and the second part that deals with removing elements from the list (and free()ing them). I would split the delete_item() into two parts. Since the create_item() is calling malloc() I would expect the delete_item() to call free(). You are leaking the list item when you delete it.
Why do your list handling functions not take a list as a parameter?Īs a result your application can only have one list. The output: 23:28: ~$ gcc -o ll linked_list.c This is a complete example that can be compiled and tested. Printf("found in first element: %i\n", x) I wondered what other people's is or if there the use current->next != NULL to be one behind (that is, to test the first element explicitly This is _my_ standard solution to the problem. So, it shall follow the same algorithm, and then we can try to think of any modifications to find its length also. Well, the very first task that I can observe is to determine whether the LinkedList contains a cycle or not. Hence, this shall return 6 as the answer.
We're looking for the best way to right this. The above-Linked List has a loop that has 6 nodes in the loop/cycle. New = (struct node *) malloc (sizeof(struct node)) lets delete all odd numbers for effect. initialise a linked list with a few items
So, is there a cleaner way to write the delete_item() function? #include a special case), then as it goes through the iteration, it's not checking iter, it's checking iter->next, ahead of the iterator's present location, because in a singly linked list you can't go backwards.
#Removing a loop in a linked list stack overflow code#
What seems inelegant to me about my solution below, although I don't know a better way to express it, is that the code needs to check the first record individually (i.e. Is what I have the 'typical' or 'normal' solution? Are there more elegant ones? I'm looking for the most commonly used style for writing the delete_item() function of a singly linked list, that find a matching item and deletes it.
0 kommentar(er)
